VirtusLab
Small corrections for gcp cloudrun example
It was for me to make this example work at all.
On Mon 26. Feb 2024 at 10:23, Paweł Prażak @.***> wrote:
@.**** commented on this pull request.
In examples/gcp-cloudrun/README.md https://github.com/VirtusLab/besom/pull/405#discussion_r1502279218:
```bash
- gcloud auth application-default login # this is required for pulumi to reach GCP
this is covered under prerequisites but we can mention it here as well ;)
the thing is this is only one of the ways to authenticate to gcp, so it might be required, and probably will for newcommers
— Reply to this email directly, view it on GitHub https://github.com/VirtusLab/besom/pull/405#pullrequestreview-1900345649, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBVNUREQM2IEJGXSCZ7O23YVRIA7AVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBQGM2DKNRUHE . You are receiving this because you authored the thread.Message ID: @.***>
The fuck? I did uncomment it. Uh, let me fix this.
On Mon 26. Feb 2024 at 10:24, Paweł Prażak @.***> wrote:
@.**** commented on this pull request.
In examples/gcp-cloudrun/infra/project.scala https://github.com/VirtusLab/besom/pull/405#discussion_r1502280717:
@@ -1,6 +1,6 @@ //> using scala "3.3.1" //> using options -Werror -Wunused:all -Wvalue-discard -Wnonunit-statement -//> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2" +///> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2"
if we are disabling it why not remove instead of commenting out?
— Reply to this email directly, view it on GitHub https://github.com/VirtusLab/besom/pull/405#pullrequestreview-1900348039, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBVNUTTE4JWPNWMICTDF3DYVRIEZAVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBQGM2DQMBTHE . You are receiving this because you authored the thread.Message ID: @.***>
We can try to bump scala-cli version and see if it resolves the JVM version clash.
Won't help. I'll remove jdk21 changes.
On Wed 28. Feb 2024 at 09:36, Paweł Prażak @.***> wrote:
We can try to bump scala-cli version and see if it resolves the JVM version clash.
— Reply to this email directly, view it on GitHub https://github.com/VirtusLab/besom/pull/405#issuecomment-1968477850, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBVNUWQGKGUVWNQCEGAJI3YV3UCRAVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGQ3TOOBVGA . You are receiving this because you authored the thread.Message ID: @.***>