strapi-plugin-navigation icon indicating copy to clipboard operation
strapi-plugin-navigation copied to clipboard

feat: extending schema validators and on update server errors details displayed

Open CodeVoyager opened this issue 5 months ago • 2 comments

Ticket

https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/issues/561

Summary

  • save errors are propagated through controller to client
  • extending zod schemas available to the consumers of plugin

Test Plan

  • add a new schema update on bootstrap (failing) (see README.md)
  • add a new lifecycle hook that will fail
  • start server
  • try to update a navigation
  • server error details should be available to in BE response (without a stack)

CodeVoyager avatar Jun 21 '25 09:06 CodeVoyager

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (fb71af3) to head (8ca24c5). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/src/controllers/admin.ts 86.66% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   88.88%   90.46%   +1.57%     
==========================================
  Files          19       19              
  Lines         288      346      +58     
  Branches       42       56      +14     
==========================================
+ Hits          256      313      +57     
+ Misses         31       30       -1     
- Partials        1        3       +2     
Flag Coverage Δ
unittest 90.46% <97.05%> (+1.57%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 21 '25 13:06 codecov[bot]

@CodeVoyager rebase please to resolve conflicts.

cyp3rius avatar Jun 23 '25 12:06 cyp3rius

@CodeVoyager rebase please to resolve conflicts.

Fixed, @cyp3rius

CodeVoyager avatar Jun 28 '25 07:06 CodeVoyager