strapi-plugin-navigation
strapi-plugin-navigation copied to clipboard
fix: navigation creation
Ticket
https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/issues/414
Summary
What does this PR do/solve?
On creation of a navigation newly created entity is not visible. This is caused by not connecting newly created entity with a locale. Then in next step navigations with no locale are ignored. In result there's an orphan entity with no connection with i18n.
Test Plan
- start the app
- go to admin panel
- create a navigation
- newly created navigation should be visible in all navigations list
Codecov Report
Attention: Patch coverage is 62.50000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 52.24%. Comparing base (
0f9934f
) to head (34de894
).
Files | Patch % | Lines |
---|---|---|
server/services/admin.ts | 60.00% | 2 Missing :warning: |
server/i18n/navigationSetupStrategy.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 51.83% 52.24% +0.40%
==========================================
Files 31 31
Lines 1115 1116 +1
Branches 332 335 +3
==========================================
+ Hits 578 583 +5
+ Misses 534 530 -4
Partials 3 3
Flag | Coverage Δ | |
---|---|---|
unittest | 52.24% <62.50%> (+0.40%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bump
Thank you for your work @CodeVoyager, would be great to get this fix rolling because enabling i18n practically breaks the Navigation plugin currently.