strapi-plugin-navigation
strapi-plugin-navigation copied to clipboard
Fix: bad strict comparison String/Number
Ticket
https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/issues/350
Summary
What does this PR do/solve?
This PR fix the problem of entity not being selected correctly in the item modal because formik use a string named "related" but compared of Number "id".
I believe the same problem may still occur in other places, there was almost identical PR merged recently: https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/pull/344.
Maybe it would be a good idea to parse the content type item id to String as soon as it is fetched. That would require adding
contentTypeItems: (isArray ? contentTypeItems : [contentTypeItems]).map(item => ({
...item,
id: String(item.id), // add parsing ID to string
__collectionUid: get(fetchedContentType, 'collectionUid', modelUID),
})),
in https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/blob/master/admin/src/pages/DataManagerProvider/index.js#L219.
I don't know the plugin code well enough, and I'm so I decided to add just the "local" fix for now.
Test Plan
@strapi/strapi 4.11.2
strapi-plugin-navigation 2.2.11
- Create collection type
Pagewith fieldtitleof typeText - Set
titleinName fieldsin navigation plugin settings - Add new menu item by selecting existing
Pageentity - Menu item is created with the title of
Pageentity (this was not the case before the fix, nothing was happening when you clickSave)
@krzysztofkaszanek Are you currently working on Strapi?
@cyp3rius since the ticket was solved, I guess you could close this PR.
Closing.