Pehkui icon indicating copy to clipboard operation
Pehkui copied to clipboard

[Performance Problems] Pehkui

Open Virtuoel opened this issue 2 years ago • 9 comments

Report performance issues you have with Pehkui here.

It is highly recommended to add a profiling report in your comment. You can create one by using the Spark mod and its profiler commands. For more info, check these links: https://spark.lucko.me/docs/Command-Usage https://modrinth.com/mod/spark https://www.curseforge.com/minecraft/mc-mods/spark

If your performance issue is specifically when Pehkui is used with another mod, add a comment to the corresponding issue from this list. If the mod has no issue yet, create a new issue and I'll add it to the list:

  • https://github.com/Virtuoel/Pehkui/issues/376
  • No other issues yet

Virtuoel avatar Feb 22 '23 23:02 Virtuoel

Here is a Spark profiler report (not by me) showing entity tick times being greatly exacerbated by Pehkui. As you can see from the bookmarks, the majority of the time appears to be spent by the mixin that modifies bounding boxes retrieving the scale using ScaleUtils.

https://spark.lucko.me/pLFykk8HZU?hl=483,332

embeddedt avatar Jun 29 '23 15:06 embeddedt

Looking through that profile, it shows 99% of the time coming from ItemEntity collision checking, which to me sounds like some contraption is overflowing way too many items onto the ground.

Virtuoel avatar Jun 29 '23 15:06 Virtuoel

This is true, but in any case Pehkui is clearly adding enough overhead to that to be visible in the profiler.

embeddedt avatar Jun 29 '23 15:06 embeddedt

This is months past the original post of this issue, but Pekhui is the biggest performance hit on my server with almost 4% of the total 8% of the thread that is being taken up being done by grabbing scale data; couldn't this be done async?

image

https://spark.lucko.me/9lwL919s2Z

JosTheDude avatar Nov 24 '23 21:11 JosTheDude

Im also having similar things happening image https://spark.lucko.me/wv23LsFXCR

1356RYAN avatar Dec 23 '23 05:12 1356RYAN

I'm having hella lag, it seems to be pehkui but im particulary new to this so i could be wrong image https://spark.lucko.me/eC6NVNsq1h

Freyr-VM avatar Mar 14 '24 02:03 Freyr-VM

Same

souldbminersmwc avatar May 12 '24 18:05 souldbminersmwc

Same, working with bewitchment and Improved mobs 1 20 1 fabric imaаge

VerdantVerger avatar Jun 23 '24 20:06 VerdantVerger

Only during the Rain and Thunder weather, Pehkui's server thread usage is very high and lags the server. On any other weather, clear, rain, there is no lag at all. https://spark.lucko.me/xRuK4qFLAn

Deceasedcraft modpack

Here is a spark link for when it is not rain and thunder https://spark.lucko.me/gWiGETQvUL

ISSUE SOLVED: Foxes were the issue smh https://bugs.mojang.com/browse/MC-179916

miyoshikai avatar Jul 18 '24 02:07 miyoshikai