vplanet icon indicating copy to clipboard operation
vplanet copied to clipboard

fixed issue #150

Open Rohit-R2000 opened this issue 3 years ago • 2 comments

Ice height is initialized at 1 on line 641

Rohit-R2000 avatar May 16 '21 20:05 Rohit-R2000

Codecov Report

Merging #152 (cede8bc) into master (7da65c7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files          24       24           
  Lines       30975    30975           
=======================================
  Hits        22880    22880           
  Misses       8095     8095           
Impacted Files Coverage Δ
src/poise.c 60.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7da65c7...cede8bc. Read the comment docs.

codecov-commenter avatar May 16 '21 20:05 codecov-commenter

Thanks, Rohit, but unfortunately this change won't fix the problem. That lTmp variable is the line number in the input file, so your change will make the code think that this option was set on line 1 of the input file. I think you need to change the default value in InitializeOptionsPoise. Note that you can verify your change worked by checking the log file.

RoryBarnes avatar May 17 '21 16:05 RoryBarnes