virtualcoffee.io icon indicating copy to clipboard operation
virtualcoffee.io copied to clipboard

Convert `loadMdx.server.js` to TypeScript

Open danieltott opened this issue 2 years ago • 6 comments

Note for Hacktoberfest:

Virtual Coffee is reserving all open issues for Virtual Coffee members for the month of October.

Find out more about becoming a member


File

app/util/loadMdx.server.js

Issue Context

  • Used to load in mdx files in the remix app.

  • loadMdxDirectory is a recursive function - it can call itself

  • Be sure to add some comments to the type definitions.

    Check out this for an example of what I mean (example code compliments of @JoeKarow): https://github.com/Virtual-Coffee/virtualcoffee.io/blob/80028b4cba8b190d2931d8284f9278417e5ed82c/app/util/cmsimage.ts

    Those comments can include markdown and we're generally following TSDoc - they result in nice things like this in code editors:

    image

Blockers

  • None

danieltott avatar Oct 10 '22 20:10 danieltott

I'd like to try this one! :)

sadiejay avatar Oct 19 '22 20:10 sadiejay

@sadiejay its all you!

danieltott avatar Oct 19 '22 20:10 danieltott

@sadiejay Are you still interested in this one?

danieltott avatar May 26 '23 16:05 danieltott

Sorry I dropped this! I'd be happy to continue to tackle it with some help! But if you don't have the bandwidth to help me like before, then you can pass it to someone else :)

On Fri, May 26, 2023 at 12:17 PM Dan Ott @.***> wrote:

@sadiejay https://github.com/sadiejay Are you still interested in this one?

— Reply to this email directly, view it on GitHub https://github.com/Virtual-Coffee/virtualcoffee.io/issues/691#issuecomment-1564626083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVCCK7NE2L6XXLKFAAN4DDXIDJQTANCNFSM6AAAAAARBVGZDE . You are receiving this because you were mentioned.Message ID: @.***>

sadiejay avatar May 26 '23 21:05 sadiejay

Expression of Interest: Convert loadMdx.server.js to TypeScript

Hello Virtual Coffee community,

I've come across the fascinating Virtual Coffee project for the first time, and I must say I'm impressed by the wonderful environment you've created for developers. The laid-back conversations, online events, and the spirit of supporting developers at all stages of their journey are truly commendable!

After going through the issues, I find the "Convert loadMdx.server.js to TypeScript" task intriguing and aligned with my expertise in TypeScript and web development. I'm eager to dive deeper into the project and contribute my skills to further enhance it.

Initial Understanding

From what I understand, the task involves converting the file app/util/loadMdx.server.js to TypeScript. I see that loadMdxDirectory is a recursive function, and I'll make sure to handle it with care during the conversion. Adding meaningful comments to the type definitions is a priority to improve code maintainability.

Commitment to Quality

As an experienced developer, I have a strong background in TypeScript, and I assure you of my commitment to delivering high-quality code. I'll meticulously review and test my changes before submitting a well-crafted pull request.

Collaboration

As a newcomer to the project, I'm excited to collaborate with the Virtual Coffee community and maintainers. I'll be proactive in seeking guidance and following the project's guidelines to ensure my contributions align seamlessly with your vision.

Conclusion

I'm genuinely thrilled at the prospect of contributing to Virtual Coffee and supporting developers through this project. I look forward to the opportunity to work with all of you and make a meaningful impact.

Thank you for considering my expression of interest!

Best regards, MMW

Mohsin-mw avatar Aug 02 '23 02:08 Mohsin-mw

@Mohsin-mw go for it!

danieltott avatar Aug 06 '23 16:08 danieltott