obsidian-git icon indicating copy to clipboard operation
obsidian-git copied to clipboard

[Bug]: If the git remote address can't established, the plugins can't use and no tips.

Open YangAoLib opened this issue 1 year ago • 4 comments

Describe the bug

When the git remote address is not established, the plugin will be unusable with no prompts.

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

the console no error info.

Steps to reproduce

  1. Remove the known_host file from the SSH directory.
  2. Open Obsidian.

Expected Behavior

Display an error message or a pop-up for user confirmation when the URL is not specified.

Addition context

No response

Operating system

Windows

Installation Method

None

Plugin version

2.23.2

YangAoLib avatar Sep 02 '24 09:09 YangAoLib

I'm unsure what your exact issue is. Can you push or pull? If not please try pulling from the terminal.

Vinzent03 avatar Sep 09 '24 20:09 Vinzent03

When I remove the known_host file, I can't pull and push in the obsidian. I can operate in the terminal. At first, I didn’t know what caused it until I ran the pull command in the terminal.

So, I think the error tips is necessary.

YangAoLib avatar Sep 11 '24 03:09 YangAoLib

But what exactly happens when you try to pull in Obsidian? Does it just load infinitely? When you pull in the terminal, shouldn't it ask you to re-add the host to the known_host file? So that afterward it works again in Obsidian?

Vinzent03 avatar Sep 11 '24 13:09 Vinzent03

Sure, after I pull in the terminal, it can do well. In Obsidian, nothing transpires. Consequently, we must incorporate prompts within Obsidian to alert users to the presence of an ongoing issue.

YangAoLib avatar Sep 13 '24 02:09 YangAoLib

This should be fixed now in v2.30.0 because the SSH_ASKPASS env variable is set to communicate with Obsidian ui.

Vinzent03 avatar Nov 25 '24 18:11 Vinzent03