[bug] `DisableNotification` setting does not work on obsidian git mobile (iOS).

[andylizf]

Maybe because there is no check for the DisableNotification setting before raise a Notice in file isomorphicGit.ts

[Vinzent03]

Some commands can take a while. So I want the user always to know that the command is still running. I may delay the notice so that they come only up if the task takes like > 5 seconds. Which notices are disturbing you in particular?

[OpenMindAmir]

It shows all notifications even if you disable notifications (In Android too)

[Vinzent03]

@mwxgaf Notifications like

• Everything is up-to-date
• Committed n files
• Pulled n files
• Pushed n files

shouldn't be shown. You should see notifications like Getting Status or progress notifications.

[OpenMindAmir]

yes yes this is right I had not paid attention this is not about all notifications

You should see notifications like Getting Status or progress notifications

By the way do you have any plan to fix this?

thank you for your great plugin :rose:

[green-codes]

The spec is that only errors are shown, all other notifications should be silenced.

I depend on Obsidian Git for syncing all my vaults and have all auto backup options on, and it’s quite annoying to be bombarded by status updates every time I startup the iOS app. Hope this is fixed soon.

Great plug-in, can’t live without it, and thanks for your good work :)

[OpenMindAmir]

For a temp solution I commented all Notice lines in the JS file

[Vinzent03]

Should be fixed now. If the status command takes longer than 20s I'm still showing a notification to let the user know a task is running long.

[bd-g]

I am getting an error with the new pull request

TypeError: undefined is not an object (evaluating progressNotice.noticeEl')

Although this may be unrelated - just updated from 2.8.0 to 2.9.2

[bd-g]

@Vinzent03 just implementation details - for example, in file obsidian-git/src/isomorphicGit.ts, a sample change is below

// This used to ALWAYS be a Notice object - now it can be undefined
const progressNotice = this.showNotice("Initializing pull");
...
...
// progressNotice is used here, but if it is undefined it will fail
(progressNotice as any).noticeEl.innerText = this.getProgressText("Checkout", progress);

I will see if there is a fix in the next day or two. If not, I may try to find time to make a PR with my own fix.

[echo-saurav]

Am i suppose to see "finish pull" every time?? . i get this notification on ios

[Vinzent03]

@echo-saurav Should be fixed now!