[BUG] socks5 proxy

[wanghaisheng]

Describe the bug

  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/botright.py", line 26, in new_browser
    _proxy = await ProxyManager(self, proxy)
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/async_class.py", line 173, in __await__
    yield from self.create_task(
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 28, in __ainit__
    self.split_proxy()
  File "/Users/wenke/miniconda3/lib/python3.9/site-packages/tsup-0.1.16-py3.9.egg/tsup/botright/modules/proxy_manager.py", line 68, in split_proxy
    raise SplitError(f"Proxy Format ({self.proxy}) isnt supported")
tsup.botright.modules.proxy_manager.SplitError: Proxy Format (socks5://127.0.0.1:1080) isnt supported

Code Sample If applicable, add a code sample to replicate the bug.

To Reproduce

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Version [e.g. 22]

Additional context Add any other context about the problem here.

[gryffus]

Do I understand it correctly, that there is currently no way to get SOCKS5 working with botright?

[wanghaisheng]

i can say last i try is failure, currently i have no idea

[gryffus]

Why did you close it, then? 🤣 @wanghaisheng

[gryffus]

@wanghaisheng can you please reopen the issue? It's not solved yet. Thanks.

[wanghaisheng]

@gryffus why bother that? for a year without any response

[gryffus]

This is not how development works. The author does this in his free time and does not "owe" you any fixes or implementation. Not even communication.

Regardless, the issue is still existing and thus there is no reason to close it yet. "It takes too long" is not a reason for closing an issue.

If you want it implemented sooner, just sponsor the project and I am sure it will get through :).

[gryffus]

Please reopen the issue. Thanks @wanghaisheng

[Vinyzu]

Issue will be worked on (someday).

[gryffus]

Thanks @Vinyzu