VinylMusicPlayer icon indicating copy to clipboard operation
VinylMusicPlayer copied to clipboard

"Used but not declared pref keys" popup on settings page

Open treeflowers opened this issue 1 year ago • 1 comments

Describe the bug A clear and concise description of what the bug is.

After entering the settings page, this popup will display. This is after re-installing and exporting/importing settings. I have toggled the settings that these error messages correspond to repeatedly, and the popup does not go away.

To reproduce Steps to reproduce the behavior:

  1. Open app
  2. Go to settings
  3. Popup appears

Expected behavior A clear and concise description of what you expected to happen.

Popup does not appear every time

Device info Please complete the following information. Or if you get directed here from the app, you can paste the collected device info.

  • Device: Samsung Galaxy S22 Ultra
  • Android Version: 14
  • Vinyl Music Player Version: 1.11.0

Additional context Add any other context about the problem here. If applicable, add screenshots to help explain your problem.

Screenshot_20240913_125352_Vinyl Music Player

treeflowers avatar Sep 13 '24 17:09 treeflowers

I have the following Used but not declared pref keys

  • ignore_media_store_artwork -- removed in 65cf71d7
  • blurred_album_art -- removed in ecf0f6b6
  • album_art_on_lockscreen -- also removed in ecf0f6b65
  • colored_app_shortcuts -- was changed on d7de0ae98 to should_color_app_shortcuts.
  • make_widget_background_transparent -- changed on d7de0ae98 to should_make_widget_background_transparent.

I strongly think that this popover should be changed to an Android logging call, since these old preferences are explainable and do not cause harm.

lhardt avatar Oct 22 '24 20:10 lhardt