Vinifera icon indicating copy to clipboard operation
Vinifera copied to clipboard

[Vanilla Bug] Unable to translate `Mission Accomplished`, `Mission Failed`, `You Are Victorious`, `Game Over` via `Language.dll`

Open MahBoiTranslator opened this issue 1 year ago • 0 comments

First Check

  • [X] I added a very descriptive title to this issue.
  • [X] I used the GitHub search to find a similar issue and didn't find it.
  • [X] I have attached as much information as possible (screenshots, debug and exception logs, etc).

Description

While I was translating Twisted Insurrection, The Second Tiberium War, Tiberian Sun Client, a bug was discovered that the mission/game ending text (Mission Accomplished, Mission Failed, You Are Victorious, Game Over) cannot be translated via the Language.dll library. When translating Language.dll with Resource Hacker into Russian, the text in the library is changed to Windows-1251 encoded text, also known as CP-1251. All editable text is displayed correctly in the game, but there is an exception with the end of mission/game text.

Required Code (optional)

No response

Steps To Reproduce

  1. Open Language.dll via hex editor, for example Resource Hacker;
  2. Replace Mission Accomplished or Mission Failed text with your mother tongue (for me it's russian);
  3. Save changes;
  4. Replace in client Resources folder original .dll file;
  5. Launch game and finish mission.

Expected Behaviour

Translated text.

Actual Behaviour

Displayed text with broken encoding. In russian case text in Language.dll was in CP-1251, but game try to read it somehow like UTF-8. tiberian_sun-2023-10-08-10_08_48

Additional Context

Tiberian Sun Client bug example: https://github.com/Vinifera-Developers/Vinifera/assets/56169197/53fe0882-9e52-4fe2-9ee6-6fdbfe804d61

The Second Tiberium War bug example: https://github.com/Vinifera-Developers/Vinifera/assets/56169197/0390457f-cd8e-462e-a549-3f45d62c14b0

Twisted Insurrection bug example: https://github.com/Vinifera-Developers/Vinifera/assets/56169197/88f70da4-90e0-4cc5-8101-a07def9b4688

MahBoiTranslator avatar Oct 08 '23 16:10 MahBoiTranslator