Tranquille icon indicating copy to clipboard operation
Tranquille copied to clipboard

wip: Migrate from greandao to sqldelight

Open Vinetos opened this issue 1 year ago • 1 comments

#6

UPDATE 17/04: As the old code of the application is very messy. I have chosen to rewrite all denylist activities in this MR. I know it may take a long time, but not doing it will postpone the problem.

Vinetos avatar Apr 14 '24 19:04 Vinetos

I would suggest using (on top of what you already did) SQLite from Requery: https://github.com/requery/sqlite-android

See the "Why?" section of the README.

Can be summed up as:

Using this library, you can keep up to date with the latest versions of SQLite and provide a consistent version across OS versions and devices.

papjul avatar Apr 27 '24 20:04 papjul

@Vinetos Do you need help with the PR?

papjul avatar Nov 08 '24 17:11 papjul

@Vinetos Do you need help with the PR?

Actually, A lot of thing happened and make me forget this work-in-pogress.

As I remember, most of the functionality were working but not fully tested. If you have time, that would be awesome !

Vinetos avatar Nov 10 '24 08:11 Vinetos

As I remember, most of the functionality were working but not fully tested.

Do you use this branch as your daily app, or do you still use YACB? If you are using it since April, I believe it should be rather stable for the main purposes.

From what I read, you began rewriting all denylist activities, are all the features complete?

If my testing looks good, can I move on to some cleanup? The project is rather old and its base code needs some modernizing to ensure its reliability in the future. A rewrite (one file at a time) in Kotlin would also be nice for DX and to make the code safer from NullPointerExceptions.

papjul avatar Nov 10 '24 09:11 papjul

As I remember, most of the functionality were working but not fully tested.

Do you use this branch as your daily app, or do you still use YACB? If you are using it since April, I believe it should be rather stable for the main purposes.

From what I read, you began rewriting all denylist activities, are all the features complete?

If my testing looks good, can I move on to some cleanup? The project is rather old and its base code needs some modernizing to ensure its reliability in the future. A rewrite (one file at a time) in Kotlin would also be nice for DX and to make the code safer from NullPointerExceptions.

I use this version daily, yes.

To be honest, I can not remember all denylist activities features activities are completed or not. I completely uninstall the app and start new tests now.

In any case, I am ready to start clean-up and start a rewrite to Kotlin

Vinetos avatar Nov 11 '24 10:11 Vinetos

I've been using a debug build for the last few weeks, and I think it's ready to be merged for a release. What do you think?

papjul avatar Feb 08 '25 09:02 papjul

Yep ! Me too !

Vinetos avatar Feb 08 '25 10:02 Vinetos