tracing-laravel icon indicating copy to clipboard operation
tracing-laravel copied to clipboard

Drop support for some older versions of PHP and Laravel in the next major release

Open adiachenko opened this issue 3 years ago • 7 comments

At the moment our versions constraints are brittle and its getting harder to anticipate where things might break due to wide range of supported software.

I suggest to limit support to the following versions to ease maintenance burden:

  • PHP >= 7.4 (support for PHP 7.3 will end on December 6)
  • Laravel >= 6.0 (this is the last version that still receives security fixes)

This also allows us to clean up some other dependencies a bit:

  • "openzipkin/zipkin": "~2.0.2|~3.0" => "~3.0"
  • "phpunit/phpunit": "~7.0|~8.0" => "~9.0"

Users of older PHP/Laravel can still avail of older versions of the package.

Opinions? @Mulkave @KinaneD

adiachenko avatar Nov 18 '21 14:11 adiachenko

+1

On Thu, Nov 18, 2021, 15:08 Alexander Diachenko @.***> wrote:

At the moment our versions constraints are brittle and its getting harder to anticipate where things might break due to wide range of supported software.

I suggest to limit support to the following versions to use maintenance burden:

  • PHP >= 7.4 (support for PHP 7.3 will end on December 6)
  • Laravel >= 6.0 (this is the last version that still receives security fixes)

This also allows us to clean up some other dependencies a bit:

  • "openzipkin/zipkin": "~2.0.2|~3.0" => "~3.0"
  • "phpunit/phpunit": "~7.0|~8.0" => "~9.0"

Users of older PHP/Laravel can still avail of older versions of the package.

Opinions? @Mulkave https://github.com/Mulkave @KinaneD https://github.com/KinaneD

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Vinelab/tracing-laravel/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAWVZOSL36JOVHQEBFDUMUCHRANCNFSM5IJWTJTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jcchavezs avatar Nov 18 '21 14:11 jcchavezs

+1

KinaneD avatar Nov 18 '21 17:11 KinaneD

Though I just noticed that Zipkin 3.0 has not been released yet.

KinaneD avatar Nov 18 '21 17:11 KinaneD

It is been released today.

On Thu, Nov 18, 2021, 18:53 Kinane @.***> wrote:

Though I just noticed that Zipkin 3.0 has not been released yet.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Vinelab/tracing-laravel/issues/41#issuecomment-973115388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAWH2PRG3F4CXVL4UA3UMU4TBANCNFSM5IJWTJTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jcchavezs avatar Nov 18 '21 18:11 jcchavezs

Yeah, Zipkin 3 has been released and there is #40 on review to tag our own v2.1.0 (final) release that includes it.

adiachenko avatar Nov 18 '21 19:11 adiachenko

It was indeed. Thank you @adiachenko @jcchavezs 🦾

KinaneD avatar Nov 19 '21 10:11 KinaneD

Good idea 👍

Mulkave avatar Nov 19 '21 18:11 Mulkave