cdn icon indicating copy to clipboard operation
cdn copied to clipboard

Moving config to .env

Open kshitijpurwar opened this issue 7 years ago • 3 comments

The CDN config such as region and bucketname should be moved to .env since it constitues sensitive info as well.

kshitijpurwar avatar Aug 05 '17 09:08 kshitijpurwar

You only have to put in your config the env variable, like this example:

 'region' => env('AWS_S3_REGION', 'us-west'),

uselessscat avatar Oct 03 '17 19:10 uselessscat

@arie-cwhat What you say is absolutely correct but it's not included the code by default which I suppose it should be because a newbie like me could just put all the sensitive info there and get my self screwed later on. @Mulkave

kshitijpurwar avatar Oct 05 '17 07:10 kshitijpurwar

I understand :+1: it's terrible to rewrite the whole history of git just to delete a line of code.

uselessscat avatar Oct 06 '17 12:10 uselessscat