tarn.js icon indicating copy to clipboard operation
tarn.js copied to clipboard

Reduce dependency on Bluebird

Open kibertoad opened this issue 5 years ago • 6 comments

I think the only remaining part that still uses Bluebird is .reflect part, will require some more tinkering to remove all of it.

kibertoad avatar Apr 12 '20 15:04 kibertoad

Gah, CI seems to be down. Submitted https://github.com/Vincit/tarn.js/pull/50 to have a fallback

kibertoad avatar Apr 12 '20 15:04 kibertoad

Circle CI is now setup. You could try to rebase this to see if it runs automatically for all the PRs now.

elhigu avatar Apr 15 '20 11:04 elhigu

@elhigu Not until it is enabled from CircleCI side. I could do that if I had admin access, or you can go to circleci and authenticate via GitHub

kibertoad avatar Apr 16 '20 23:04 kibertoad

Ah, it is already running on master, so I assume you did the setup already. Awesome! I'll sync the branch.

kibertoad avatar Apr 16 '20 23:04 kibertoad

@elhigu For some reason it triggers on master but not for branches. Is execution on branches enabled from CircleCI side?

kibertoad avatar Apr 16 '20 23:04 kibertoad

now it should be enabled also for forked PRs

elhigu avatar Apr 17 '20 07:04 elhigu