Vincent Rouvreau

CMake FetchContent fails to install oneTBB

1

I tried to install oneTBB with cmake FetchContent feature with these few lines of CMake: ```cmake cmake_minimum_required(VERSION 3.11) project(cmake_fetch_content_onetbb VERSION 0.0) set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED True) include(FetchContent) FetchContent_Declare( tbb GIT_REPOSITORY https://github.com/oneapi-src/oneTBB.git...

CMake find_package with a minimal CGAL version number does not detect properly 6.X CGAL version

4

## Issue Details CMake `find_package(CGAL 5.1.0)` (with a minimal cgal version number) does not seem to behave as expected with master version. ## Source Code Here is a CMake file...

Fix #967 New Delaunay complex module: - The Delaunay complex filtration values computed with different techniques: * Delaunay complex (without filtration values) * Delaunay Čech complex (using minimal enclosing ball...

`src/Cech_complex/example/cech_complex_example_from_points.cpp` fails to compile with CGAL 5.1, but it is fixed in CGAL 5.1.5+: ``` In file included from /custom-cgal/include/boost/none_t.hpp:17, from /custom-cgal/include/boost/none.hpp:17, from /custom-cgal/include/boost/optional/optional.hpp:60, from /custom-cgal/include/boost/optional.hpp:15, from /CGAL-5.1/include/CGAL/Object.h:30, from /CGAL-5.1/include/CGAL/kernel_basic.h:25,...

Const simplex tree unitary tests and fix operator== and !=

3

This PR is based on and replaces #1119

Fix #80 and #771

Additionnal data in Simplex_tree are not copied

1

Data in simplices was introduced in #1105 but these data are not copied when copying a Simplex_tree. Should we do it ? Or just say in doc these data are...

I can see multiple `_is_prime` implementations in Persistence_matrix module: * https://github.com/GUDHI/gudhi-devel/blob/f23c15477d65209ba682b36d898b3770234598a9/src/Persistence_matrix/include/gudhi/Fields/Zp_field.h#L405 * https://github.com/GUDHI/gudhi-devel/blob/f23c15477d65209ba682b36d898b3770234598a9/src/Persistence_matrix/include/gudhi/Fields/Multi_field_small_operators.h#L493 * https://github.com/GUDHI/gudhi-devel/blob/f23c15477d65209ba682b36d898b3770234598a9/src/Persistence_matrix/include/gudhi/Fields/Multi_field_small.h#L390 * https://github.com/GUDHI/gudhi-devel/blob/f23c15477d65209ba682b36d898b3770234598a9/src/Persistence_matrix/include/gudhi/Fields/Multi_field_operators.h#L440 + a new implementation that comes with Ripser new module : https://github.com/mglisse/gudhi-devel/blob/8cab8c9e3695846278f3b8fd8095715bbc8e5950/src/Ripser/include/gudhi/ripser.h#L158 We...