vincent guyader comments

Results 56 comments of


                                            vincent guyader

install_local(upgrade="never") doesn't allow to install the golem package-app

@tottidici and @agronomofiorentini can you share (privately ? ) your whole project with Colin and/or me ? 90% of chance that the issue is in your package, but in that...

add_dockerfile() should use GITHUB_PAT when calling remotes::install_github

Hi, have à look to the add_dockerfile_with_renv function :)

add_dockerfile() should use GITHUB_PAT when calling remotes::install_github

hi yes, we have a little trouble to finalize the transition to golem 0.3.3 which contains the function :) you can install golem with : `remotes::install_github("thinkr-open/golem@temp_renv") ` then run `golem::add_dockerfile_with_renv(output_dir...

add_dockerfile() should use GITHUB_PAT when calling remotes::install_github

yes indeed I had misunderstood the request, had passed too quickly on the side "private repos". I have no use case to test on my side. maybe it's clear for...

add_dockerfile() should use GITHUB_PAT when calling remotes::install_github

yes, PR welcome :)

add_dockerfile_with_renv() should check non-R files containing R code

Your check should return 0 error 0 warning to be sure to create thé propre dockerfile. Have a look to attachment::att_amend_desc() for help

covr considers only the first instance of expect_snapshot in a test

Thank you for these investigations. We just stumbled upon this issue today. I see that a merge request has been accepted, but indeed the issue is still present.

Golem apps should not have to import {golem}

update : the actual dev branch just get a slimming cure. the number of Import is very low (and quite close to shiny itself)

Golem apps should not have to import {golem}

\o/

Turn Dockerfile to `{dockerfiler}` object

done