react-native-confetti-cannon icon indicating copy to clipboard operation
react-native-confetti-cannon copied to clipboard

Published 20 hours ago • verified publisher icon VincentCATILLON

feat(ui): non full-windowed support

Open bertrand-caron opened this issue 3 years ago • 5 comments

Description

Add support for non-fullscreen confetti. Useful if using a navbar, or any other component that obscures part of the screen. behaviour is backwards compatible (defaults to Dimensions.get('window')).

Result

N/A

Related issues

N/A

bertrand-caron avatar Jul 29 '21 00:07 bertrand-caron

@VincentCATILLON Bumping in case you have not seen this yet and are interested :)

bertrand-caron avatar Aug 09 '21 00:08 bertrand-caron

@VincentCATILLON Are you still maintaining this repository, or is there a better place to merge this?

bertrand-caron avatar Oct 12 '21 05:10 bertrand-caron

Sorry @bertrand-caron about the delay, I'll make a review asap

VincentCATILLON avatar Sep 30 '22 15:09 VincentCATILLON

Hi @bertrand-caron

Thanks for your nice contribution

I think the prop should be more explicit (dimensions instead of window which is not really appropriate for container dimensions usage imho), can you adjust and i'll publish it ? :)

VincentCATILLON avatar Sep 30 '22 15:09 VincentCATILLON

Can this get merged @VincentCATILLON would be helpful

buchereli avatar Mar 06 '23 05:03 buchereli