react-native-confetti-cannon icon indicating copy to clipboard operation
react-native-confetti-cannon copied to clipboard

Published 20 hours ago • verified publisher icon VincentCATILLON

fix(layout): performances optimization

Open uragirii opened this issue 3 years ago • 6 comments

Description

This PR implements the conditional rendering of the children according to animation. When the animation is running, the View nodes are mounted and they are unmounted after the animation finishes. I've also implemented 2 tests to test this behavior. This should provide a performance boost in the case of low-end devices. Unnecessary children are not rendered.

Related issues

  • [x] #51 Android App is slow after using this library

uragirii avatar Jul 14 '21 20:07 uragirii

This PR is awesome. Would love to see it merged.

alexcastillo avatar Aug 23 '21 20:08 alexcastillo

Seems like a great change. Would also vote to merge this and get a new version published!

corbt avatar Sep 21 '22 19:09 corbt

Voted.

chrisedington avatar Sep 22 '22 18:09 chrisedington

@VincentCATILLON can we get this merged?

uragirii avatar Sep 26 '22 08:09 uragirii

I think you should create a new repository, Vincent seems to have abandoned the project unfortunately

jonathanroze avatar Sep 30 '22 11:09 jonathanroze

Hi @uragirii @alexcastillo @corbt @chrisedington @jonathanroze ,

Sorry about the delay. I'll take a look and post a review to be able to publish it as soon as possible 🙏

Thanks in advance for your contribution

VincentCATILLON avatar Sep 30 '22 15:09 VincentCATILLON