spark-ffm icon indicating copy to clipboard operation
spark-ffm copied to clipboard

features to complete

Open VinceShieh opened this issue 8 years ago • 6 comments

I summarize the current design and come out with a few things that can be done to make spark-ffm better. 1. add global bias intercept and one-way interactions, current design only support pairwise interactions 2. normalization support

It'd be nice if any of you are interested in working on this project, you are always welcome and I will try best to help. :)

VinceShieh avatar Jan 23 '17 01:01 VinceShieh

hello, I have used your ffm to train some model in big data, but the tr_loss turns out to be NaN when the data size is larger than 1000000, please do a favor

lmxiaonuo avatar Sep 14 '17 03:09 lmxiaonuo

@lmxiaonuo I have also encountered this problem. Have you solved it?

Thinkgamer avatar Jul 10 '18 08:07 Thinkgamer

I just made a PR for this issue, you can get it from https://github.com/VinceShieh/spark-ffm/pull/16 and test on your end. And also please open an issue if the problem still exists.

VinceShieh avatar Jul 11 '18 11:07 VinceShieh

@VinceShieh I have sloved it! thank you

Thinkgamer avatar Jul 13 '18 16:07 Thinkgamer

@Thinkgamer did u resolve the issue with the PR I submitted or some other means you tried? If the PR works, I will merge it. Thanks.

VinceShieh avatar Jul 16 '18 10:07 VinceShieh

@VinceShieh I did not try your PR,I did some processing on the features. Next I will test your changes and then send feedback. Thank you.

Thinkgamer avatar Aug 07 '18 06:08 Thinkgamer