Vinai Kopp

Happy to provide any info. Not 100% sure what is required after reading this thread. Regarding the hyva theme detection, what we do to determine if a theme is a...

You an use the latter, but a `setHelperTestDouble` would be a convenient wrapper for manipulating the registry manually. Would you consider making a small PR out of that?

What I thought of was that the method `setHelperTestDouble` is part of the `DigitalPianism_TestFramework_Model_Config` simply for convenience. In that method it would build the helper registry key, `Mage::unregister()` it -...

This would be excellent!

Same happens for PHP 7.2 ``` vagrant@magento2:~$ php --version Failed loading /usr/lib/xdebug72/modules/xdebug.so: /usr/lib/xdebug72/modules/xdebug.so: cannot open shared object file: No such file or directory PHP 7.2.16-1+ubuntu14.04.1+deb.sury.org+1 (cli) (built: Mar 7 2019...

The problem happens at this stage of the buld in `scripts/provision/upgrade_environment_recurring.sh`: ``` git clone git://github.com/xdebug/xdebug.git xdebug72 fatal: could not create work tree dir 'xdebug72'.: Permission denied ``` The issue is...

Ran into problems with that, too, while using composer in a `vagrant ssh` session. Maybe `./scripts/host/composer.phar` can be copied to `/usr/local/bin/composer`?

:+1: Especially with PSR-4 using namespaces to reflect the folder structure, they are not a good component indicator. Being able to use the `@package` class annotation and have it being...

Isn't this kind of superfluous noise? * The target class of the plugin is visible as the first argument of every plugin method (e.g. `public function beforeDispatch(\Magento\Framework\App\Action\Action $subject)`) * The...

@navarr > For plugins that are intercepting more than one class the target class cannot be declared in the signature. This is only true if the plugin is used to...