vint icon indicating copy to clipboard operation
vint copied to clipboard

Ignore ProhibitNoAbortFunction for functions that cannot fail (static return)

Open blueyed opened this issue 9 years ago • 1 comments

Do you think it makes sense to ignore the "Use the abort attribute for functions in autoload (see Google VimScript Style Guide (Functions))" policy in case the function just returns a string?

We're using vint for Neomake, and its makers often just return a static string, dict or list and I think the "abort" might not be required there?!

I can see that it is a good habit in general (although I do not fully understand why), but it causes linting job failures for PRs because of legacy code.

What do you think? Feel free to close this as out-of-scope, of course.

blueyed avatar Sep 17 '16 23:09 blueyed

Make sense.

But I think that this feature do not have high priority. So, I will implement it after resolving more critical issues such as #121.

Kuniwak avatar Sep 20 '16 14:09 Kuniwak