covimerage icon indicating copy to clipboard operation
covimerage copied to clipboard

Minimal Windows CI with GitHub Action

Open rhysd opened this issue 5 years ago • 6 comments

Related to #90

Hi,

This PR adds a minimal Windows CI with GitHub Action. It only runs unit tests and takes coverage with Python 3.8.

Here is an example of CI result:

https://github.com/rhysd/covimerage/runs/416425706?check_suite_focus=true

Currently several tests fail but I don't know the failures are due to #90.

Do unit tests run with tox require vim or nvim editor command? Currently they are not installed. Please let me know if they are necessary. I'll add step to install them.

EDIT: If you want to put a CI badge for this in README.md, please let me know. I'll do.

rhysd avatar Jan 30 '20 03:01 rhysd

I also added Python 3.5, 3.6, 3.7. 3.4 is not supported by setup-python action.

rhysd avatar Jan 30 '20 04:01 rhysd

I fixed 21 failures but 4 failures are remaining. They look hard for me to fix since expectations are not clear for me.

https://github.com/rhysd/covimerage/runs/416658292?check_suite_focus=true

And there are a few test failures which may be related to #90.

>       assert exit_code == 0, (err, out)
E       AssertionError: ('Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python
E         Python runtime state: preinitialized
E         
E         ', '')
E       assert 1 == 0
E         -1
E         +0

and

E       assert 'Error: The profile file (/not/used) has not been created.' in ['Running cmd: python -c \'import pty; pty.spawn([\'"\'"\'/bin/sh\'"\'"\', \'"\'"\'-c\'"\'"\', \'"\'"\'printf output; ..., '    import tty', '  File "c:\\hostedtoolcache\\windows\\python\\3.8.1\\x64\\Lib\\tty.py", line 5, in <module>', ...]
E        +  where ['Running cmd: python -c \'import pty; pty.spawn([\'"\'"\'/bin/sh\'"\'"\', \'"\'"\'-c\'"\'"\', \'"\'"\'printf output; ..., '    import tty', '  File "c:\\hostedtoolcache\\windows\\python\\3.8.1\\x64\\Lib\\tty.py", line 5, in <module>', ...] = <built-in method splitlines of str object at 0x000002435754ECA0>()
E        +    where <built-in method splitlines of str object at 0x000002435754ECA0> = 'Running cmd: python -c \'import pty; pty.spawn([\'"\'"\'/bin/sh\'"\'"\', \'"\'"\'-c\'"\'"\', \'"\'"\'printf output; e...   from termios import *\r\nModuleNotFoundError: No module named \'termios\'\r\nError: Command exited non-zero: 1.\r\n'.splitlines

rhysd avatar Jan 30 '20 07:01 rhysd

'Better Code Hub' CI fails but I don't have permission to see the results.

rhysd avatar Jan 30 '20 07:01 rhysd

'Better Code Hub' CI fails but I don't have permission to see the results.

You can ignore it, it's just an experiment.

blueyed avatar Feb 15 '20 04:02 blueyed

Current status:

FAILED tests/test_cli.py::test_coverage_plugin_for_annotate_merged_conditionals
FAILED tests/test_cli.py::test_cli_xml - assert ('filename="%s' % local('D:\\...
FAILED tests/test_cli.py::test_run_handles_exit_code_from_python_pty_fd - ass...
FAILED tests/test_coveragepy.py::test_coveragewrapper_uses_config_file - json...
=================== 4 failed, 80 passed, 2 skipped in 8.23s ===================

https://github.com/rhysd/covimerage/runs/416658292?check_suite_focus=true

I can look into them during the next days. I plan to spent some time for coverage 5 support here anyway soon.

blueyed avatar Feb 15 '20 04:02 blueyed

what's the status of this PR, is it able to be merged?

wsdjeg avatar Aug 08 '23 17:08 wsdjeg