Blockly2Java icon indicating copy to clipboard operation
Blockly2Java copied to clipboard

Improve ignored blocks handling

Open ivukomanovic opened this issue 8 years ago • 2 comments

While parsing statements with multiple child blocks, it seems that in some situations simply incrementing/decrementing the ignoreBlocks counter is not sufficient. Specifically, I encountered the issue in the case of statement containing two child blocks, each of which contains two values and the values being blocks themselves. In this case one of the values in the second child is parsed incorrectly (resulting in null value). This is demonstrated in the provided test case testMultiValueBlock. The proposed solution involves keeping track of the specific block id's which should be ignored, instead of just incrementing the counter when node named 'next' is encountered and decrementing it on the next encountered closing block tag.

ivukomanovic avatar Apr 07 '17 12:04 ivukomanovic

Coverage Status

Coverage increased (+0.4%) to 88.276% when pulling b4918f3bd000a6c6da27952a71ebbaf3cc6d538a on ivukomanovic:master into 68a6246e699f5967e222520a53ac3983a3160d8d on Vilsol:master.

coveralls avatar Apr 07 '17 13:04 coveralls

Hi @Vilsol, @ivukomanovic, @coveralls

Pleas see this issue

Please help me on this. Thank you.

praveenb avatar Dec 03 '18 15:12 praveenb