Viktor Lindgren

Hi so a small thing i have is that , The messages such as you need to repair and spirit bond goes over the debug channel, so you can configure...

I use a 5 second wait between food and recepie in my Lua scripts. It might have something to do with race conditions i would suggest adding a longer wait...

Im not totally sure how the docker build and push works as i personally use buildah but it should be the same logic, as you set the enviroment variable on...

> > It's probably worth doing #1161 as part of this PR or in a follow up PR I have a quick question then. Shall i put the get version...

> @ViktorLindgren95 Thanks a lot for your effort! The direction looks very good. Implementation-wise, I have two comments- would you mind reviewing those comments and, if that makes sense to...

> > The default didn't seem to take when I tested (built using the Makefile `make docker-buildx`). Additionally, the Makefile needs adjusting to support passing in a version if desired...

> mmmm looks like some changes are needed: > > 1. https://github.com/actions-runner-controller/actions-runner-controller/blob/master/Makefile#L7 needs to become `dev` instead of latest > > 2. https://github.com/actions-runner-controller/actions-runner-controller/blob/master/Makefile#L121 a --build-arg added for passing in VERSION...

> I set it as N/A to make debugging easier instead of an empty message. Changes have been made

Just a simple const that we set manually each update that print at the start of init/main function call or is there an internal version handling that should be called...

Would be great, would make handling cross dependencies with deploy keys a lot easier