viewtouch icon indicating copy to clipboard operation
viewtouch copied to clipboard

unused-but-set-variables

Open NeroBurner opened this issue 6 years ago • 1 comments

I'm trying to squash some warnings. With the following variables I have no Idea what they should be doing. Can you shed some light on them? Maybe they were intended to do/check something

l_width https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/zone/layout_zone.cc#L233

status https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/zone/dialog_zone.cc#L2105

ismanager https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/zone/dialog_zone.cc#L2111

term_hardware https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/term/term_main.cc#L50

firstmod https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/main/check.cc#L1450

labor_percent https://github.com/ViewTouch/viewtouch/blob/44fa2989bff24e3f3e1f18c10f8aede05cc9a5cc/main/system_report.cc#L448

can they savely be removed? or should they be used for something?

NeroBurner avatar Jul 17 '18 21:07 NeroBurner

I'm on the road for about the next 3 hours. I'll reply when I am back in Eugene.

I wish I had the knowledge to answer this, but I simply don't. If you can determine that they are not used then you could make them remarks so that if something breaks it will be easy to restore the variable responsible.

GeneMosher avatar Jul 17 '18 21:07 GeneMosher