binance-api-node icon indicating copy to clipboard operation
binance-api-node copied to clipboard

futuresCancelBatchOrders lacks return-type annotation

Open bennycode opened this issue 2 years ago • 3 comments

The PR https://github.com/ViewBlock/binance-api-node/pull/586 introduced type definitions for futuresCancelBatchOrders. 🚀

Unfortunately, the function is missing a return-type definition which becomes a problem when trying to use it with strictly typed code:

binance-api-node/index.d.ts:666:5 - error TS7010: 'futuresCancelBatchOrders', which lacks return-type annotation, implicitly has an 'any' return type.

@jinusean do you know what the function returns or is it just Promise<void>?

P.S. It's funny that the error occurs in line 666. 😈

bennycode avatar Aug 08 '23 11:08 bennycode

How did you solve this problem? What is the best temporary way?

uslualper avatar Dec 01 '23 09:12 uslualper

How did you solve this problem? What is the best temporary way?

I downgraded to binance-api-node v0.12.6 - Does it work for you as well?

bennycode avatar Dec 01 '23 12:12 bennycode

I can probably revert the PR if @bennycode confirms, not a type expert

balthazar avatar Dec 02 '23 23:12 balthazar