binance-api-node icon indicating copy to clipboard operation
binance-api-node copied to clipboard

Published 20 hours ago • verified publisher icon ViewBlock

Delivery futures

Open ubarbaxor opened this issue 2 years ago • 3 comments

Add HTTP and WebSocket stuff for delivery API

Note : I'm writing this for my own needs, and am currently still werking on it. Unit tests aren't there yet, and I'm yet to test it in production. Mostly opening the MR with [WIP] flag to open discussion.

Rationale : I'm currently working on a project where I needed access to the delivery API. Rather than writing an adapter with custom requests, I figured I'd be about as quick contributing to this one. I did my best to follow the original code style and design lines as closely as relevant.

ubarbaxor avatar Sep 12 '22 21:09 ubarbaxor

Thanks that looks promising! Would you mind removing the changes to the package.json and yarn.lock as they are out of scope of this PR?

balthazar avatar Sep 13 '22 01:09 balthazar

No trouble, that's done ;)

Also cleaned up the commit history.

ubarbaxor avatar Sep 13 '22 16:09 ubarbaxor

Added tests, fixed package.json / yarn.lock edits. Removing [WIP].

ubarbaxor avatar Sep 13 '22 21:09 ubarbaxor

Hey @balthazar I've finished writing the docs. Things are tested, both in the suite and live (fork has been in production for a couple weeks now).

What do you think, can we get this upstream ?

ubarbaxor avatar Oct 03 '22 22:10 ubarbaxor

Do you mind running prettier on all files? I think I saw some extra spaces in test files, otherwise looking very good!

balthazar avatar Oct 04 '22 00:10 balthazar

Do you mind running prettier on all files? I think I saw some extra spaces in test files, otherwise looking very good!

Done ! Good catch.

ubarbaxor avatar Oct 04 '22 11:10 ubarbaxor

💯 Thank you! Will draft a new minor for that one

balthazar avatar Oct 04 '22 13:10 balthazar