binance-api-node icon indicating copy to clipboard operation
binance-api-node copied to clipboard

Published 20 hours ago • verified publisher icon ViewBlock

allMiniTickers or allMiniTicker ?

Open hemon opened this issue 4 years ago • 2 comments

in Readme is [allMiniTickers], but in code and test is named [allMiniTicker] without "s"

hemon avatar Oct 08 '21 14:10 hemon

allMiniTicker is also expecting a payload parameter which is usually used to determine which symbols to subscribe to, but it's not necessary in this case. You have to pass a random parameter (not an empty array) to get it working. In my opinion, it should be removed, correct me if I'm wrong.

DamiToma avatar Dec 01 '21 10:12 DamiToma

in version 0.11.28. Its make me creazy, when document say allMiniTickers, but function is allMiniTicker, and the break me heard is you missing type definition allMiniTicker(s), its make me sad :'( Any here can make PR for this issues?

FahriDevZ avatar Jan 02 '22 13:01 FahriDevZ