vienna-rss icon indicating copy to clipboard operation
vienna-rss copied to clipboard

Renaming feeds/folders looks awful

Open DavidMunch opened this issue 7 years ago • 9 comments

Renaming feeds and folders produce an editing field overlay with a different font size, instead of editing the name inline. It looks pretty bad. :)

viennarenaming

Vienna 3.1.10, but not a new issue.

DavidMunch avatar Jul 01 '17 09:07 DavidMunch

There will be a PR for this soon.

josh64x2 avatar Jul 28 '17 07:07 josh64x2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 28 '20 13:09 stale[bot]

Still an issue.

DavidMunch avatar Sep 28 '20 14:09 DavidMunch

Experiencing this issue as well :)

nivivier avatar Jan 20 '21 11:01 nivivier

On macOS 11, it looks correct with light appearance but it is still awful with dark appearance.

@DavidMunch and @nivivier , which version of macOS do you use ?

barijaona avatar Feb 01 '21 14:02 barijaona

@barijaona - @Eitot and myself have made good progress on using view based cells for the whole feed list. We are waiting for the WebKit branch to merge before we finish it off and then it will fix this issue.

josh64x2 avatar Feb 01 '21 19:02 josh64x2

I am on 10.15. It looks like you narrowed it down well @barijaona :

  • Light mode : when starting to rename, the item cell background changes to white, covering the old name, then the new text we type is readable
  • Dark mode : the cell background remains transparent, leaving the old name visible which makes this text-on-text issue, making it impossible to read what we type in.

nivivier avatar Feb 01 '21 19:02 nivivier

On macOS 11, it looks correct with light appearance but it is still awful with dark appearance.

@DavidMunch and @nivivier , which version of macOS do you use ?

Vienna 3.7.1 on macOS 11.1 - Both newest releases. I see the issue with both in light and dark mode.

Screenshot 2021-02-01 kl  21 09 19 Screenshot 2021-02-01 kl  21 09 46

DavidMunch avatar Feb 01 '21 20:02 DavidMunch

It admittedly looks bad, but at least it is still functional. In any case, there is a work-in-progress branch for a modern sidebar style, but it needs to wait until the WebKit stuff is merged, since both touch the same Interface Builder files. There are some issues that still need to be resolved though.

Eitot avatar Feb 01 '21 21:02 Eitot