vienna-rss icon indicating copy to clipboard operation
vienna-rss copied to clipboard

Misleading Syncing Preferences window

Open barijaona opened this issue 2 years ago • 2 comments

Describe the bug Users having a FreshRSS account report they are unable to connect to it using Vienna. They get messages "A server with the specified hostname could not be found". https://github.com/FreshRSS/FreshRSS/issues/3417

When I tried to reproduce the problem with a test account, I noticed in my debug info something similar to (redacted):

Task <A7944B2B-497A-4087-9A08-C634E50C7800>.<1> finished with error [-1003] Error Domain=NSURLErrorDomain Code=-1003 "A server with the specified hostname could not be found" 
....
NSErrorFailingURLStringKey=https://https://freshrss.example.com/api/greader.php/accounts/ClientLogin?accountType=GOOGLE&service=reader

(note the double sequence https://https:// in the URL)

It occurred to me that Vienna's syncing preferences dialog is misleading. The window suggests to input a complete URL, while the user should only provide a hostname and a path. In the above example, I immediately got correct access once I replaced https://freshrss.example.com/api/greader.phpwith freshrss.example.com/api/greader.php in my settings.

Screenshots In previous versions of Vienna, the preference window was more explicit about what was expected. Here is a 3.5.3 screenshot : an https:// string does show on the window, as an advice to the user to avoid inputting any scheme. Vienna 3 5 3

This changed once we switched to a storyboard based window (commit 5dfb7a1) The current display is completely misleading: master

Additional information: Change occurred with Version 3.6.

barijaona avatar Sep 20 '22 10:09 barijaona

@Eitot , do you see a more elegant (and localizable) solution than just replacing the URL: label with URL: https:// ?

barijaona avatar Sep 20 '22 10:09 barijaona

In any case, what about accepting both inputs with and without scheme? You can always add an explicit scheme such as https:// if is not provided by the user. That is what Web browsers have been doing for years

Alkarex avatar Sep 20 '22 10:09 Alkarex

I agree with Alkarex that ideally Vienna should just allow a full or partial URL and maybe reject other schemes. I suppose I changed the string at the time because I thought it was odd.

It would be cool though if the text field could have the always https:// filled in without allowing the user to remove it, to make it clear that whatever the user enters will have this scheme. I think I have seen a UI like this somewhere, but I cannot recall where I've seen it.

Eitot avatar Sep 29 '22 18:09 Eitot