vienna-rss icon indicating copy to clipboard operation
vienna-rss copied to clipboard

Stabilize width of article list

Open barijaona opened this issue 2 years ago • 7 comments

With the "Load Full HTML" setting enabled, changes of article list width were sometimes seen. The problem was reported by @josh64x2 in #1596 and I have also seen it with some sites.

We modify holding priorities for subviews of SplitView2 Need feedback to make sure this change is good enough for any website.

barijaona avatar Jul 17 '22 06:07 barijaona

Seems to work better with old browser than with new browser.

Any ideas ?

barijaona avatar Jul 17 '22 06:07 barijaona

OK I was also unable to fix the vertical layout in master until I turned off the new browser preview, so it wasn't caused by this PR.

I do have reliable way of reproducing a broken Vertical layout though so let me try and debug this over the next couple of days!

josh64x2 avatar Jul 21 '22 06:07 josh64x2

It appears to me that, for some unknown reason, some WkWebView will get higher content compression resistance priority / content hugging priority than legacy WebView

barijaona avatar Jul 23 '22 06:07 barijaona

I haven't had a chance to debug yet, but now the vertical layout is broken and I'm unable to resize it:

And it's worst on 10.12… 😟

barijaona avatar Jul 23 '22 06:07 barijaona

New version submitted. I have tried many approaches, but could not find anything simpler that covers all the combinations I tested. Tested with vertical layout and "Load full HTML" enabled on feeds https://www.lemonde.fr/rss/une.xml and http://www.confidential-renault.fr/?rss=RSS You need to test with a combination of feeds with and without Load full HTML" enabled.

barijaona avatar Aug 11 '22 19:08 barijaona

I do have reliable way of reproducing a broken Vertical layout though so let me try and debug this over the next couple of days!

Do you reproduce the problem with my latest version ?

barijaona avatar Aug 11 '22 19:08 barijaona

I am currently unable to test on older versions of macOS. If anyone can provide feedback, it will be welcomed.

barijaona avatar Aug 11 '22 21:08 barijaona

I will test this tomorrow and let you know how it goes!

josh64x2 avatar Aug 14 '22 08:08 josh64x2