vienna-rss icon indicating copy to clipboard operation
vienna-rss copied to clipboard

GitLab Activity Feed: Inline Pictures in Issues break Vienna Sync

Open sbondorf opened this issue 3 years ago • 3 comments

Describe the bug GitLab has an activity overview (Project Information > Activity) RSS feed that includes, among other news items, comments to issues. As with GitHub, these comments can show pictures inline instead of linking them as attachments by adding an exclamation mark in front:

  • inline syntax: ![name](line_to_pic)
  • attachment syntax: [name](line_to_pic)

Adding an inline picture breaks Vienna synchronization. Other RSS readers (tested with NetNewsWire) keep sync'ing, though.

To Reproduce

  • Subscribe to a GitLab repository's activity feed
  • Create an issue
  • Comment on the issue, include an inline picture

Screenshots I've set up this public repository to demonstrate the issue: https://gitlab.com/sbondorf/rsstestsvienna/-/issues/1 Screen Shot 2022-02-10 at 12 32 08

Screen Shot 2022-02-10 at 12 32 22

Link to W3 Feed Evaluation

Please complete the following information:

  • Version 3.8.0 Beta 2
  • macOS 12.2, Intel

Additional information: Was present in previous versions, too, sorry for not reporting earlier

sbondorf avatar Feb 10 '22 11:02 sbondorf

Hey @sbondorf , it looks like this feed doesn't validate with W3 either ?

josh64x2 avatar Mar 14 '22 06:03 josh64x2

Hi, you're right, and patching such a problem in the RSS application instead of fixing the source is not that great, I know. Turns out, it neither validates if the image is declared an attachment and Vienna synchronizes properly. I hope increasing Vienna's resilience against malfomatted sources is on the agenda.

Attached are my two validations, working == image attached and broken == image shown inline

Does Vienna maybe share common libraries with NetNewsWire that is not affected by this?

sbondorf avatar Mar 15 '22 09:03 sbondorf

GutLab provides a feed for issues only, instead of all activities (including changes to Wiki articles, project memberships, etc.).

Here's the link https://gitlab.com/sbondorf/rsstestsvienna/-/issues.atom

This feed does not validate either but with different problems (a subset, I think).

The sample project only has a single issue, it breaks Vienna's ability to subscribe to the Activity Feed but not the Issues Feed. Interesting find, I hope that helps debugging.

sbondorf avatar May 02 '22 10:05 sbondorf