operator icon indicating copy to clipboard operation
operator copied to clipboard

Unknown usage of VMServiceScrape included in kustomize

Open tumd opened this issue 2 years ago • 2 comments

Hi,

The file config/prometheus/monitor.yaml is included when installing by kustomize. But I fail to understand what this specific VMServiceScrape-manifest is good for. At least it's not matching anything in any of my GKE or k3s clusters.

To me it looks like something legacy that probably should not be included in a clean install of the operator. Or am I missing something?

tumd avatar Nov 21 '23 14:11 tumd

On a related note, why is namePrefix specified in the default kustomize target? IMHO this should not be specified here, and should instead be up to the user to set, if desired. To my knowledge, it can not be unset by the user.

tumd avatar Nov 22 '23 08:11 tumd

Hello, I think kustomize config is outdated and not tested properly. We recommend to use helm for operator deployment.

Feel free to open PR with fixes for kustomize.

f41gh7 avatar Dec 01 '23 13:12 f41gh7