operator icon indicating copy to clipboard operation
operator copied to clipboard

Hope to add ScrapeConfig CRD

Open linuxduduniao opened this issue 1 year ago • 8 comments

Related functions have been provided by Prometheus Operator ScrapeConfig

linuxduduniao avatar Nov 05 '23 14:11 linuxduduniao

@Amper @Haleygo WDYT?

f41gh7 avatar Nov 16 '23 16:11 f41gh7

Yeah, I think we can implement it as a generic scrape configuration for all service discoveries.

Haleygo avatar Nov 17 '23 04:11 Haleygo

Must support sharding for ScrapeConfig

linuxduduniao avatar Nov 21 '23 11:11 linuxduduniao

Must support sharding for ScrapeConfig

Can you elaborate here? You mean to shard targets from one scrape job to several vmagents?

Haleygo avatar Nov 22 '23 08:11 Haleygo

Must support sharding for ScrapeConfig

Can you elaborate here? You mean to shard targets from one scrape job to several vmagents?

For example, when reading the instances address from consul (node_exporter, icmp, applications deployed on virtual machines), when there are many instances, I need to use sharding to solve a single vmagent performance issue.

linuxduduniao avatar Nov 23 '23 08:11 linuxduduniao

I want deploy vmagents on Kubernetes, these vmagents scrape all targets within the cluster( serverMonitor, podMonitor ...) and outside the cluster(scrapeConfig). Management CRD configuration by gitops (argocd + gitlab)

linuxduduniao avatar Nov 23 '23 08:11 linuxduduniao

For example, when reading the instances address from consul (node_exporter, icmp, applications deployed on virtual machines), when there are many instances, I need to use sharding to solve a single vmagent performance issue.

This is already implemented on vmagent by shardCount, see https://new.docs.victoriametrics.com/operator/resources/vmagent/?highlight=shardcount#sharding. ScrapeConfig CRD will be a config resource like other scrape CRDs, help generating scrape_config file.

Haleygo avatar Nov 23 '23 10:11 Haleygo

This is already implemented on vmagent by shardCount, see https://new.docs.victoriametrics.com/operator/resources/vmagent/?highlight=shardcount#sharding. ScrapeConfig CRD will be a config resource like other scrape CRDs, help generating scrape_config file.

Thanks. Because prometheus operator not support sharding for ScrapeConfig , so I wanted vm operator support sharding for ScrapeConfig

linuxduduniao avatar Nov 23 '23 10:11 linuxduduniao

Must be fixed at v0.43.0 release

Operator now supports ScrapeConfig and implements own version with VMScrapeConfig

f41gh7 avatar Apr 18 '24 09:04 f41gh7