operator icon indicating copy to clipboard operation
operator copied to clipboard

Populate VMRule `.status` with information about the vmrule resource

Open cskinfill opened this issue 2 years ago • 1 comments

It would be great to have the .status of the VMRule resource be populated with information like:

  • if the rule matched the schema correctly
  • timestamp loaded by vmalert
  • etc

cskinfill avatar Oct 31 '23 20:10 cskinfill

Hello!

if the rule matched the schema correctly

The CRD Validation should be done by validation admission webhook before it's created successfully, see https://github.com/VictoriaMetrics/operator/blob/c720cb4452f386b11de95c24d02a47800246f56d/docs/configuration.md?plain=1#L231 As for other fields that vmalert might validate, I think the error should stay in vmalert since it's vmalert which determine configuration is right or wrong and it could change between different version of vmalerts. And if expected rules didn't appear in vmalert, users should find error messages in it's log.

timestamp loaded by vmalert

Since vmrule is only a source of config file and vmalert loads it dynamically, why do you need it under vmrule's status?

Haleygo avatar Nov 01 '23 08:11 Haleygo