operator icon indicating copy to clipboard operation
operator copied to clipboard

VictoriaLogs

Open uhthomas opened this issue 1 year ago • 4 comments

Does the operator support VictoriaLogs? If not, are there plans too?

uhthomas avatar Jul 03 '23 10:07 uhthomas

Hello, yes, we've such plans, but there is not ETA for it.

And it'll be challenging. Current CRD bundle almost exceed 1MB limit.

f41gh7 avatar Jul 05 '23 04:07 f41gh7

And it'll be challenging. Current CRD bundle almost exceed 1MB limit.

I think you may actually be okay. There are multiple CRD objects, and the cumulative size is not relevant to the 1M size limit. Only if an individual object exceeds 1M will it be a problem.

https://github.com/kubernetes/kubernetes/issues/82292

uhthomas avatar Jul 19 '23 02:07 uhthomas

I've made some research.

Current the only way for adding VictoriaLogs - completely remove any k8s server side validation. CRD will have only spec definition with preserve unknown true annotation.

For actual validation, webhook must be used.

I propose, to add VictoriaLogs as Deployment and use the same behavior as VMSingle does.

cc @Amper @Haleygo

f41gh7 avatar Sep 26 '23 08:09 f41gh7

@f41gh7

Current the only way for adding VictoriaLogs - completely remove any k8s server side validation. CRD will have only spec definition with preserve unknown true annotation.

For actual validation, webhook must be used.

I think it may leads problems for some users due:

  • they use CRD specification with different handy k8s tools (like kubectl explain / kubectl explore).
  • they doesn't use webhooks because:
    • it block resource deploy when the operator is not running - pipelines will be failed
    • therefore, this requires HA mode deployment and load scaling
    • require certificates

Amper avatar Sep 28 '23 09:09 Amper