operator icon indicating copy to clipboard operation
operator copied to clipboard

The meaning of name field in VMStorage, etc

Open umezawatakeshi opened this issue 4 years ago • 3 comments

The structures like VMStorage have the name field. However, this field have no documentation.

I first expected that this field specifies the name of StatefulSet for vmstorage itself. But actually the field specifies the suffix of the name. i.e. the .spec.vmstorage.name field of a VMCluster is bar-storage, the name of the StatefulSet for vmstorage becomes vmstorage-bar-storage, not bar-storage. (I do not necessarily expect this behavior to change)

umezawatakeshi avatar Oct 07 '21 06:10 umezawatakeshi

Oh, sorry, don't know how i skip this issue.

It was designed to allow u default name override for VMCluster object, prefix was added by mistake to it.

But it must be deprecated and removed from spec. Because it's immutable field and changing it may break whole cluster.

f41gh7 avatar Nov 16 '21 13:11 f41gh7

I understood.

I used to use the feature to rename StatefulSet for a while (with my custom patch), but I don't use it anymore. So I don't have a problem if that feature is deprecated.

umezawatakeshi avatar Nov 17 '21 12:11 umezawatakeshi

at v0.21.0 it became deprecated. Will be removed at the v0.22.0 release.

f41gh7 avatar Dec 01 '21 14:12 f41gh7