metrics icon indicating copy to clipboard operation
metrics copied to clipboard

Add a Prometheus-compatible Histogram function, and convert the vmrange label to the le label

Open greyireland opened this issue 2 years ago • 3 comments

greyireland avatar Feb 07 '23 08:02 greyireland

any news here ? what can be done to help get this PR merged ?

clementnuss avatar May 23 '23 06:05 clementnuss

Hello @greyireland @clementnuss! I don't think it is a good idea to convert VictoriaMetrics histograms in Prometheus histograms because the former histograms are sparse with dynamic buckets. While standard Prometheus histograms are static and the whole logic for processing Prometheus histograms relies on that logic. For example, if instance A will produce 10 buckets for query latency histogram, and instance B will produce 11 buckets - the aggregation of 99th latency percentile for instance A and B will be calculated incorrectly. So in fact, this change will result into confusion and incorrect processing results. Prometheus standard histograms should have static buckets across all application instances.

hagen1778 avatar May 23 '23 07:05 hagen1778

@hagen1778 that's a good point and in that case it may make more sense to add Prometheus style static buckets based Histogram in order to be fully compatible.

neal avatar Jun 13 '23 12:06 neal