helm-charts
helm-charts copied to clipboard
[Feature][operator] Argocd synchronization annotation
VictoriaMetrics operator supports adding annotations for converted object for properly comparing and syncing ArgCD objects.
| VM_PROMETHEUSCONVERTERADDARGOCDIGNOREANNOTATIONS | false | false | adds compare-options and sync-options for prometheus objects converted by operator it helps to properly use converter with ArgoCD |
It should be possible to enable it by values
@bkomraz1 hi
you can specify it already
for victoria-metrics-operator you can set env variables through env
parameter
like
env:
- name: VM_PROMETHEUSCONVERTERADDARGOCDIGNOREANNOTATIONS
value: true
for victoria-metrics-k8s-stack it uses victoria-metrics-operator
chart as a dependency
so you can also set it in the same way
victoria-metrics-operator:
env:
- name: VM_PROMETHEUSCONVERTERADDARGOCDIGNOREANNOTATIONS
value: true
its a bit confusing that we have operator and victoria-metrics-operator in chart values, we will address this in next release
@k1rk Technically you are right, but how users will know about this feature? I had to go to code of the operator to find it. I am not sure that all users will do it.
At least readme of the helm chart should have list of supported environment variables and values.yaml should reference to vars.MD file
https://github.com/VictoriaMetrics/operator/blob/master/vars.MD
but how users will know about this feature? I had to go to code of the operator to find it. I am not sure that all users will do it.
related to https://github.com/VictoriaMetrics/operator/issues/580