VictoriaMetrics icon indicating copy to clipboard operation
VictoriaMetrics copied to clipboard

streamaggr: ignore intervals instead of samples

Open AndrewChubatiuk opened this issue 11 months ago • 3 comments

AndrewChubatiuk avatar Mar 18 '24 15:03 AndrewChubatiuk

Codecov Report

Attention: Patch coverage is 35.29412% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 56.73%. Comparing base (8aaa828) to head (605de9b). Report is 485 commits behind head on master.

:exclamation: Current head 605de9b differs from pull request most recent head ce4d20b. Consider uploading reports for the commit ce4d20b to get more accurate results

Files Patch % Lines
lib/streamaggr/streamaggr.go 43.18% 21 Missing and 4 partials :warning:
app/vmagent/remotewrite/remotewrite.go 0.00% 10 Missing :warning:
app/vminsert/common/streamaggr.go 0.00% 9 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5981      +/-   ##
==========================================
- Coverage   60.37%   56.73%   -3.65%     
==========================================
  Files         411      524     +113     
  Lines       76609    72260    -4349     
==========================================
- Hits        46253    40996    -5257     
- Misses      27794    28366     +572     
- Partials     2562     2898     +336     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 20 '24 17:03 codecov[bot]

@AndrewChubatiuk shall we close it in favour of https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6137 ?

hagen1778 avatar Apr 22 '24 12:04 hagen1778

i'll close it later

AndrewChubatiuk avatar Apr 22 '24 13:04 AndrewChubatiuk