All skybox textures are PNGs

[PhoenixWhitefire]

All of them are PNGs disguised as JPEGs! It's pretty simple to confirm: Open one in Notepad, and the first few characters will identify it as a PNG:

Re-saving them as JPEGs with something Paint also cuts down their filesize by 10x - from ~3MB to ~300KB.

[sirbuig]

I think this may be related to an issue I just had moments ago...right.jpg was corrupted/ not processed properly and it refused to load. I thought it was an issue from the code and/or the file path, but reordering the files confirmed is right.jpg specific.

Nice catch tho!

[PhoenixWhitefire]

@sirbuig

I think this may be related to an issue I just had moments ago...right.jpg was corrupted/ not processed properly and it refused to load. I thought it was an issue from the code and/or the file path, but reordering the files confirmed is right.jpg specific.

Nice catch tho!

This isn't meant to be a dig at him, but I have a lot of other "catches" about the code itself, a lot of things that were really confusing once I looked into them - sometimes I wonder how long this guy was using C++ for, it's just that this one thing was especially funny to me. Maybe I will make a fork that's just my own, "cleaned" rendition of the code 😂

Oh I've looked at the PRs being actively merged, I should make a few

[VictorGordan]

@PhoenixWhitefire

Ok, that's really funny, tbh I doubt I made the PNGs into JPEGs since I generally prefer PNGs (lossless), so it's probably the sources I got them from, but then again this was a long time ago so maybe I did edit them...

This isn't meant to be a dig at him, but I have a lot of other "catches" about the code itself, a lot of things that were really confusing once I looked into them - sometimes I wonder how long this guy was using C++ for <

Thanks for being respectful, and to give you an answer, at the time of this series, probably less than a year, probably a few months.

Maybe I will make a fork that's just my own, "cleaned" rendition of the code 😂 Oh I've looked at the PRs being actively merged, I should make a few

That would be great if you have the time!

Overall there are some parts of the series I am not very proud of (the loading models episodes are hot garbage), but I think it's good to keep it up for people who prefer videos over text (since this series mostly follows learnopengl.com with some differences here and there, some good, some bad).

I hope that in the future I can post a much much better original series! :)