mollie-api-go icon indicating copy to clipboard operation
mollie-api-go copied to clipboard

Improving Balances.ContextValues Unmarshalling, Fixing #251

Open MarcoWel opened this issue 1 year ago • 4 comments

Fixes #251

MarcoWel avatar May 31 '23 18:05 MarcoWel

Hey there! Thanks for the PR, I have some follow up questions.

  1. Did you consider any alternative solution over the custom marshaller? (e.g. using a blank interface?)
  2. Could you please add some test cases for the new function?
  3. Could you have a look and fix the linter errors?

Once again, thanks for the contribution.

VictorAvelar avatar May 31 '23 19:05 VictorAvelar

  1. Nope - feel free to use an alternative solution.
  2. The solution was tested against production data. You can check an example from the issue and add it to the test data.
  3. Not sure what the linter issue should be - it works here without errors.
Running [/home/runner/golangci-lint-1.52.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: return with no blank line before (nlreturn)
  Error: return statements should not be cuddled if block has more than two lines (wsl)
  
  level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing git diff HEAD~: exit status 128"
  
  Error: golangci-lint exit with code 2

MarcoWel avatar May 31 '23 19:05 MarcoWel

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 06 '23 17:06 stale[bot]

This issue has been automatically closed because it has not had any activity after being labeled as staled.

stale[bot] avatar Jun 18 '23 04:06 stale[bot]

Fixed on #328

VictorAvelar avatar Mar 03 '24 13:03 VictorAvelar