ViaVersion icon indicating copy to clipboard operation
ViaVersion copied to clipboard

[BUG] MTVehicle Plugin not working with Viaversion

Open Tsoccerguy3 opened this issue 1 year ago • 5 comments

/viaversion dump Output

https://dump.viaversion.com/4680f2d1a76fcae8e25dfa67553366b49e5c34d4b5c5a049ea40dcd308c10743

Console Error

No error, just lack of plugin functionality

Bug Description

MTVehicles , https://github.com/GomorrhaDev/MinetopiaVehicles , not working .

Steps to Reproduce

Server is running 1.21.1 , log in with 1.21.3 client . Place a vehicle. Look steering not working. and drive is the W key does not do anything

Expected Behavior

Expect the plugin to work like on 1.21.1

Additional Server Info

No response

Checklist

  • [X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • [X] I have included a ViaVersion dump.
  • [X] If applicable, I have included a paste (not a screenshot) of the error.
  • [X] I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.

Tsoccerguy3 avatar Nov 03 '24 14:11 Tsoccerguy3

Platform: 1.21.1--131--84281ce%20%28MC%3A%201.21.1%29 ViaVersion (5.1.1): Even with master

Barvalg avatar Nov 03 '24 14:11 Barvalg

i have a similar problem with my selfcoded packet based car system. when pressing w the car drives forwart shortly then stops again i have to spam click w in order for it to kind of drive intended

FelixBrs avatar Nov 03 '24 17:11 FelixBrs

My best guess is that a undocumented event change going from Minecraft 1.21.1 to 1.21.3 and onward including the new 1.21.4 , It affects Spigot,Paper and there for Viaversion. If a coder on one of these projects, take a look here for a method change that I am not seeing src/main/java/nl/mtvehicles/core/movement/VehicleMovement.java

Tsoccerguy3 avatar Nov 29 '24 18:11 Tsoccerguy3

The problem is not in Paper 1.21.1 . Paper 1.21.1 accepts input as a vector , ViaVersion supporting 1.21.4 will only accept input as a BOOLEAN . "Player input packet no longer sends a vector, it sends a bunch of bools, you derive a vector from that, see getLastClientMoveIntent on ServerPlayer It tells you where you can see the vector derived at and allows you to mimic an implantation" .

For ViaVersion to support a 1.21.1 plugin when a 1.21.4 client logs on to the server it will need to allow vector input not BOOLEAN

Tsoccerguy3 avatar Jan 11 '25 08:01 Tsoccerguy3

The bug still exists on ViaVersion supporting 1.21.4 on Paper 1.21.1

Tsoccerguy3 avatar Jan 12 '25 20:01 Tsoccerguy3