Custom player skulls use default Steve texture

[DavixDevelop]

/viaversion dump Output

https://dump.viaversion.com/0f2bfabedb2b34d10366b3fbcaf5dfc5e5b8f5265383ae533e305055783a71c5

Console Error

No response

Bug Description

When clients connect from 1.17 up to the latest 1.20 version, to our Mohist server (1.12), that's on a proxy (Waterfall), the custom player skulls use the default Steve texture, signs don't render the text, and banners aren't rendered either.

I found out there was already a similar GitHub issue 3 years ago, and I found out it got closed as completed, so I explored the code a bit, especially, common/src/main/java/us/myles/ViaVersion/protocols/protocol1_16to1_15_2/packets/WorldPackets.java. I opened up the same class in common/src/main/java/com/viaversion/viaversion/protocols/protocol1_17to1_16_4/packets/WorldPackets.java, compared the two classes, and found out the latter one doesn't handle block entity data in line:124 ( protocol.registerClientbound(ClientboundPackets1_16_2.CHUNK_DATA,...), and neither does it register a client bound for ClientboundPackets1_16_2.BLOCK_ENTITY_DATA and handle block entity data there as well, as does the prior.

Could this be the cause of the issue or was the algorithm for 1.17 and up changed, and it handles block entity data now differently?

Screenshot comparison of the same scene in a 1.16.5 and 1.17.1 Vanilla client

Steps to Reproduce

1. Setup a Mohist server for 1.12, with the latest version for it (mohist-1.12.2-320-server.jar)
2. Connect it to a proxy (Waterfall) server
3. Connect to the Mohist server via a Vanilla 1.12 server
4. Place custom skulls (ex, via Spigot Skulls - The Ultimate Head Database or the paid Head Database plugin), place banners, place signs with text
5. Connect to the Mohist server via a Vanilla 1.17.1 or up client
6. Look at the placed skulls, signs, and banner outlines

Expected Behavior

Custom player skulls should use the custom texture, signs should render the text, and banners should be correctly rendered.

Additional Server Info

The server is connected to a proxy via Waterfall, that uses the latest version of ViaVersion as of creating this issue.

Checklist

• [X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
• [X] I have included a ViaVersion dump.
• [X] If applicable, I have included a paste (not a screenshot) of the error.
• [X] I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.

[Barvalg]

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

[DavixDevelop]

https://dump.viaversion.com/efb0971b7a57d81167d6e358cb508b11e369213ac11a66646964a3f89be597e2

[Barvalg]

[HowardZHY]

Mohist is unsupported, please try normal paper

[DavixDevelop]

Mohist is unsupported, please try normal paper

Alright, I tried both Paper 1.12 and Mohist 1.12 on a local server, connected to them via 1.12, 1.17, and 1.19 clients, and all work. It seems there's an issue when Mohist 1.12 server is on a proxy (Waterfall) that has ViaVersion, as we tested it on Build Team servers that are connected to the same network or a separate network, all clients 1.17 and up connecting to them, break BlockEntities. Also, sorry for the initial reply to your comment.

Paper comparison

Mohist comparison