ViaRewind icon indicating copy to clipboard operation
ViaRewind copied to clipboard

Delaying PacketPlayInArmAnimation for 1.8->1.9 properly

Open funkemunky opened this issue 4 years ago • 7 comments

Fully explained in the comments, but PacketPlayInArmAnimation would be sent after PacketPlayInFlying, causing false positives on anticheats. This way, they will still always be sent after PacketPlayInUseEntity but before PacketPlayInFlying.

funkemunky avatar Mar 23 '21 17:03 funkemunky

I fixed conflicts for this branch. Hopefully this can be merged into master now

funkemunky avatar Jun 21 '21 14:06 funkemunky

hmmmmm when pull @Gerrygames

xkeksi avatar Sep 11 '21 05:09 xkeksi

@Gerrygames hey when will this be put into ViaRewind? My customers who use ViaRewind are having issues with the release builds and have to keep sending them my modified versionb.

funkemunky avatar Dec 10 '21 16:12 funkemunky

When will this be merged, it's quite important to stop false bans

7Sence avatar Mar 30 '22 09:03 7Sence

When will this be merged, it's quite important to stop false bans

There is no ETA for when pull requests will be merged / checked out properly as this usually boils down to lack of time or because different things are currently planned for via* functionality at the moment.

Kichura avatar Mar 30 '22 11:03 Kichura

@Kichura okay. I mean this bit of code has been fairly well tested at this point considering the amount of servers just using a patched version with this bit of code instead of the one distributed officially.

Would be good to be implemented before this becomes a year old...

funkemunky avatar Apr 23 '22 19:04 funkemunky

Able to confirm the issue, a 1.8 player on a 1.18 server gets kicked when building due to this change: https://www.youtube.com/watch?v=OT7SGsFOCkY

MWHunter avatar Jun 06 '22 23:06 MWHunter