ViaFabric icon indicating copy to clipboard operation
ViaFabric copied to clipboard

[1.12] Memory leak

Open Tomatobird8 opened this issue 4 years ago • 3 comments

Memory usage accumulates and framerate decreases as the world is traveled. This seems to be an issue with ChunkNibbleArrays not being cleared and lighting being processed in all of those chunks.

This issue occurs on ViaFabric client connected to a vanilla 1.12.2 server as well as on a fabric client without ViaFabric, connected to a 1.12.2 PaperMC server with ViaVersion. Possibly other setups as well but these are what I've tested.

To reproduce, using a 1.17.1 client join a 1.12.2 server and explore the world for a while. May take more than 100k blocks

Heap dump memory leak suspect report using Memory Analyzer: 01 02

Tomatobird8 avatar Jul 26 '21 16:07 Tomatobird8

Does installing Sodium fixes it?

creeper123123321 avatar Jul 26 '21 23:07 creeper123123321

Does installing Sodium fixes it?

No. Memory leak/FPS Drops happen with and without sodium.

Tomatobird8 avatar Jul 27 '21 00:07 Tomatobird8

Confirmed on windows server 2019 machine without any mods other than viafabric + the api installed.

Kichura avatar Jul 27 '21 17:07 Kichura

Decided to try and recreate this problem on my new-current linux machine and this time it's not the case.

Kichura avatar Dec 28 '23 00:12 Kichura