ViaBackwards icon indicating copy to clipboard operation
ViaBackwards copied to clipboard

Villager trades for 1.20.6 servers are invisible on version 1.20.4 and below.

Open Boxeyy opened this issue 1 year ago • 14 comments

'/viaversion dump' Output

https://dump.viaversion.com/3190f75e7ac82e4d9b0cae551394ba65eeef6207a14dde804e069e30447d67ba

Console Error

N/A

Bug Description

When inputting trades in a villager on a 1.20.6+ server while on version 1.20.4 or below the result item appears invisible

Steps to Reproduce

  1. Log on with 1.20.4 or below on 1.20.6
  2. Go to a village
  3. Input the correct items for the trade
  4. Result item is invisible

Expected Behavior

The result item should be visible.

Additional Server Info

Plugins

Bukkit Plugins: (44):

  • ajLeaderboards, AntiPopup, Astro, AxVaults, CataMines, CrazyEnchantments, DecentHolograms, DeluxeCombat, DiscordSRV, Diskuise, ExcellentCrates, FastAsyncWorldEdit, InventoryRollbackPlus, ItemEdit, LibsDisguises, lightEconomy, LiteBans, LPC, LuckPerms, MysteryBoxes, MythicMobs, nightcore, packetevents, PlaceholderAPI, Plan, PlayerAuctions, PoaSkRewritev2, ProtocolLib, Shopkeepers, SkBee, SkQuery, Skript, skript-gui, skript-placeholders, spark, SunLight, TAB, Tebex, TradeSystem, Vault, ViaBackwards, ViaVersion, WorldGuard, ZNPCsPlus

Purpur version 1.20.6-2233-0d6766e (latest)

Checklist

  • [X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • [X] I have included a ViaVersion dump.
  • [X] If applicable, I have included a paste (not a screenshot) of the error.
  • [X] I have tried a build from https://ci.viaversion.com/ and the issue still persists.

Boxeyy avatar Sep 09 '24 13:09 Boxeyy

Platform: 1.20.6--2233--0d6766e%20%28MC%3A%201.20.6%29 ViaVersion (5.0.4-SNAPSHOT): 3 commits behind master ViaBackwards(5.0.4-SNAPSHOT): 1 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

Barvalg avatar Sep 09 '24 13:09 Barvalg

Still persists

https://dump.viaversion.com/fcacce23476ba7d2a616a7dc85c674856fe14e15307138f57d44a1876632286b

Boxeyy avatar Sep 10 '24 09:09 Boxeyy

Platform: 1.20.6--2233--0d6766e%20%28MC%3A%201.20.6%29 ViaVersion (5.0.4-SNAPSHOT): Even with master ViaBackwards(5.0.4-SNAPSHOT): Even with master

Barvalg avatar Sep 10 '24 09:09 Barvalg

I have the same problem

Incluuu avatar Sep 13 '24 13:09 Incluuu

image This is a MC 1.20.4 client on a 1.20.6 Paper server. I cannot reproduce your issue, are you sure it still happens with latest Via* plugins?

FlorianMichael avatar Sep 18 '24 14:09 FlorianMichael

Try it with items that have custom attributes in villager shops (new 1.20.6 ones and old ones). Still happens

Boxeyy avatar Sep 18 '24 14:09 Boxeyy

Happens for me on 1.21.1 server with 1.20.6 client

alexcastro1919 avatar Sep 19 '24 21:09 alexcastro1919

bump

Incluuu avatar Sep 24 '24 13:09 Incluuu

There is a real problem on this. When you try to trade on client version 1.20.4 and below an item that have custom name it show the result invisible but you can click on it and it works. On above versions works fines.

Image from Gyazo

Specs: Paper: 1.21 ViaVersion: 5.1.1 ViaBackwards: 5.1.1

negativems avatar Nov 04 '24 00:11 negativems

While not reproducable with vanilla villagers, Shopkeepers like this one and custom villagers from datapacks have broken outputs - therefore it is a problem.

Kichura avatar Nov 04 '24 00:11 Kichura

I am having the same issue 5.1.1 Via* and ShopKeepers plugin.

TZ122 avatar Nov 04 '24 03:11 TZ122

Has there been any progress on this?

negativems avatar Nov 08 '24 22:11 negativems

Any update on this issue? Thanks

TZ122 avatar Nov 24 '24 00:11 TZ122

please fix 🫡

Hatefsf avatar Nov 28 '24 17:11 Hatefsf