ViaBackwards icon indicating copy to clipboard operation
ViaBackwards copied to clipboard

Advancements display abnormally on the 1.20.2 server

Open MSCMDD opened this issue 1 year ago • 31 comments

'/viaversion dump' Output

https://dump.viaversion.com/6c7046a1e64ea52b52778b63b93d21bb68a906edfd2b77607183bad94b33ccb0

Console Error

Put the paste.gg link or text here.

Bug Description

The old version of Minecraft achieved abnormal results when accessing the 1.20.2 server through ViaBackwards Advancements not displaying properly

Steps to Reproduce

Log in to the 1.20.2 server using a 1.20.1 client or earlier version

Expected Behavior

Older versions of clients logging into 1.20.2 servers should display Advancements correctly

Additional Server Info

No response

Checklist

  • [X] Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
  • [X] I have included a ViaVersion dump.
  • [X] If applicable, I have included a paste (not a screenshot) of the error.
  • [X] I have tried a build from https://ci.viaversion.com/ and the issue still persists.

MSCMDD avatar Oct 15 '23 07:10 MSCMDD

Platform: git--Paper--238%20%28MC%3A%201.20.2%29 ViaVersion (4.8.1): Even with master ViaBackwards(4.8.1): 1 commits behind master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Oct 15 '23 07:10 Barvalg

https://dump.viaversion.com/9a4014b5c03d5243106b9ae6ddbd90a4021cb57e290bc37a9a9e17d3d45c767d

MSCMDD avatar Oct 15 '23 08:10 MSCMDD

Platform: git--Paper--238%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w41a-SNAPSHOT): Even with dev ViaBackwards(4.9.0-23w41a-SNAPSHOT): Even with dev

Barvalg avatar Oct 15 '23 08:10 Barvalg

https://dump.viaversion.com/9a4014b5c03d5243106b9ae6ddbd90a4021cb57e290bc37a9a9e17d3d45c767d

MSCMDD avatar Oct 15 '23 08:10 MSCMDD

Platform: git--Paper--238%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w41a-SNAPSHOT): Even with dev ViaBackwards(4.9.0-23w41a-SNAPSHOT): Even with dev

Barvalg avatar Oct 15 '23 08:10 Barvalg

Display them correctly where? What exactly does "abnormally" mean?

kennytv avatar Oct 15 '23 08:10 kennytv

For example, when I enter “advancement grant User everything” in the server console, I can see the normal feedback through the 1.20.2 client. image image However, when I use the 1.20.1 version of the client or any lower version, I cannot see the advancement progress being completed. image

MSCMDD avatar Oct 15 '23 08:10 MSCMDD

How should I configure them to enable lower version clients to display advancements correctly, or is there an error causing the issue? Could it be due to using a new version of the Paper server (Paper build explorer: #231, 5509610 Fix UnsafeValues#loadAdvancement (#9753))? emmmmmm However, even when using a previous version of the Paper server, I still cannot display advancements correctly on lower versions of clients.

MSCMDD avatar Oct 15 '23 08:10 MSCMDD

I have the same problem.

Pantera07 avatar Oct 19 '23 03:10 Pantera07

https://dump.viaversion.com/9857f770517e8cf1635ffa07ce1b1c41d1e0bbcdef2153bea6ac0be8d2a49948 https://youtu.be/yh-VYziYlaw (1.20.2 Server, 1.20.1 Client) This bug still exists.

I tried to find the cause of this but couldn't find it. Suspected: https://github.com/ViaVersion/ViaBackwards/blob/71f08b9e4e2749573cfcc1ea72fd95d3ce6ed5da/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/rewriter/BlockItemPacketRewriter1_20_2.java#L175

Pantera07 avatar Oct 26 '23 17:10 Pantera07

Platform: git--Paper--246%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w43a-SNAPSHOT): Even with dev ViaBackwards(4.9.0-23w43a-SNAPSHOT): Even with dev

Barvalg avatar Oct 26 '23 17:10 Barvalg

Same problem, but if using 1.12.2 or even lower version client, the advancements screen will show "There doesn't seem to be anything here"

Dreeam-qwq avatar Oct 29 '23 05:10 Dreeam-qwq

Same problem

Saharo4eks avatar Nov 03 '23 07:11 Saharo4eks

Same problem for latest dev build

DinoFengz avatar Nov 11 '23 15:11 DinoFengz

same problem

wd4q5dy avatar Nov 11 '23 17:11 wd4q5dy

same problem

jajader avatar Nov 12 '23 01:11 jajader

https://dump.viaversion.com/9857f770517e8cf1635ffa07ce1b1c41d1e0bbcdef2153bea6ac0be8d2a49948 https://youtu.be/yh-VYziYlaw (1.20.2 Server, 1.20.1 Client) This bug still exists.

I tried to find the cause of this but couldn't find it. Suspected:

https://github.com/ViaVersion/ViaBackwards/blob/71f08b9e4e2749573cfcc1ea72fd95d3ce6ed5da/common/src/main/java/com/viaversion/viabackwards/protocol/protocol1_20to1_20_2/rewriter/BlockItemPacketRewriter1_20_2.java#L175

Should ViaVersion use the bukkit api to get advancements Criteria? How can this issue be resolved?

Pantera07 avatar Nov 13 '23 14:11 Pantera07

Platform: git--Paper--246%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w43a-SNAPSHOT): 17 commits behind dev ViaBackwards(4.9.0-23w43a-SNAPSHOT): 7 commits behind dev

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Nov 13 '23 14:11 Barvalg

https://dump.viaversion.com/13469c25d1fc98fe8c7082d660a5fba928c152b5b186648578994e59f03e052b dump.txt

wd4q5dy avatar Nov 14 '23 01:11 wd4q5dy

Platform: git--Paper--262%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w42a-SNAPSHOT): 28 commits behind dev ViaBackwards(4.9.0-23w45a-SNAPSHOT): Even with dev

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Nov 14 '23 01:11 Barvalg

https://dump.viaversion.com/6b0edd8a5ce779fdd1425d42d616a1570651597240758b20b7554252667b590e

wd4q5dy avatar Nov 26 '23 13:11 wd4q5dy

Platform: git--Paper--262%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w42a-SNAPSHOT): 37 commits behind dev ViaBackwards(4.9.0-1.20.3-pre1-SNAPSHOT): Even with dev

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Nov 26 '23 13:11 Barvalg

Platform: git--Paper--262%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w42a-SNAPSHOT): 37 commits behind dev ViaBackwards(4.9.0-1.20.3-pre1-SNAPSHOT): Even with dev

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

https://dump.viaversion.com/a178ef326c3a6bfbe11f8ec6995abf5a846d189deacbc1f0ee12f34eb8222db2

RICE0707 avatar Dec 07 '23 13:12 RICE0707

Platform: git--Purpur--2092%20%28MC%3A%201.20.2%29 ViaVersion (4.9.2): Even with master ViaBackwards(4.9.1): Even with master

Barvalg avatar Dec 07 '23 13:12 Barvalg

平台:git--論文--262%20%28MC%3A%201.20.2%29 ViaVersion (4.9.0-23w42a-SNAPSHOT):落後開發者 37 次提交 ViaBackwards(4.9.0-1.20.3-pre1-SNAPSHOT):即使使用開發

請嘗試https://ci.viaversion.com/中的最新版本。如果問題仍然存在,請發送新的轉儲

https://dump.viaversion.com/a178ef326c3a6bfbe11f8ec6995abf5a846d189deacbc1f0ee12f34eb8222db2

1.20.4 image

1.20.3 image

1.20.2 image

1.20.1 image

1.20 image

RICE0707 avatar Dec 08 '23 04:12 RICE0707

Platform: git--Purpur--2092%20%28MC%3A%201.20.2%29 ViaVersion (4.9.2): Even with master ViaBackwards(4.9.1): 2 commits behind master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Barvalg avatar Dec 08 '23 04:12 Barvalg

Platform: git--Purpur--2092%20%28MC%3A%201.20.2%29 ViaVersion (4.9.2): Even with master ViaBackwards(4.9.1): 2 commits behind master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

https://dump.viaversion.com/4c11679206556024f63d2d7770f970b2a16521b17c6b1e4f555e96123a786a42

RICE0707 avatar Dec 08 '23 04:12 RICE0707

Platform: git--Purpur--2092%20%28MC%3A%201.20.2%29 ViaVersion (4.9.2): Even with master ViaBackwards(4.9.2-SNAPSHOT): Even with master

Barvalg avatar Dec 08 '23 04:12 Barvalg

Any progress of this advancement display issue?

Dreeam-qwq avatar Jan 08 '24 23:01 Dreeam-qwq

Any progress?

DinoFengz avatar Feb 18 '24 12:02 DinoFengz